Add tests for apiErrors and standardErrors #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandenrodgers
commented
Oct 13, 2023
| @@ -242,6 +242,6 @@ en: | |||
| fetchTaskStatus: "There was an error fetching the task status while syncing sandboxes." | |||
| fetchTypes: "There was an error fetching sandbox types." | |||
| processFieldsJs: | |||
| fieldsJsNotReturnArray: "There was an error loading JS file \"{{ path }}\". Expected type \"Array\". Make sure that your function returns an array" | |||
| fieldsJsNotFunction: "There was an error loading JS file \"{{ path }}\". Expected type \"Function\". Make sure that your default export is a function." | |||
| fieldsJsNotReturnArray: 'There was an error loading JS file "{{ path }}". Expected type "Array". Make sure that your function returns an array' | |||
There was a problem hiding this comment.
I didn't purposely do this. Maybe prettier did it?
There was a problem hiding this comment.
Ohh yep I think prettier prefers not to use escape characters when it can avoid it.
brandenrodgers
commented
Oct 13, 2023
| err.statusCode === 403 && | ||
| err.error && | ||
| err.error.category === 'MISSING_SCOPES' | ||
| export function isMissingScopeError(err: GenericError): boolean { |
There was a problem hiding this comment.
The thinking here is that we aren't sure which type of error we're going to get as an arg. The calling system may be passing something in that's more generic and doesn't necessarily have the type of StandardCodeError.
brandenrodgers
commented
Oct 13, 2023
| ): never { | ||
| const i18nKey = 'errors.api'; | ||
| const i18nKey = 'errors.errorTypes.api'; |
There was a problem hiding this comment.
I noticed we were getting missing translation errors here
camden11
approved these changes
Oct 24, 2023
| @@ -242,6 +242,6 @@ en: | |||
| fetchTaskStatus: "There was an error fetching the task status while syncing sandboxes." | |||
| fetchTypes: "There was an error fetching sandbox types." | |||
| processFieldsJs: | |||
| fieldsJsNotReturnArray: "There was an error loading JS file \"{{ path }}\". Expected type \"Array\". Make sure that your function returns an array" | |||
| fieldsJsNotFunction: "There was an error loading JS file \"{{ path }}\". Expected type \"Function\". Make sure that your default export is a function." | |||
| fieldsJsNotReturnArray: 'There was an error loading JS file "{{ path }}". Expected type "Array". Make sure that your function returns an array' | |||
There was a problem hiding this comment.
Ohh yep I think prettier prefers not to use escape characters when it can avoid it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Adding some basic unit tests to expand our test coverage. This focuses on the error utils.
Screenshots
TODO
Who to Notify