Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logErrorInstance message builder #958

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Fix logErrorInstance message builder #958

merged 1 commit into from
Nov 28, 2023

Conversation

adamawang
Copy link
Contributor

Description and Context

logErrorMessage was migrated back from cli-lib (original file here) but an additional parens was added, causing some error messages to not display correctly. Screenshots below of a sandboxes example (ignore the deprecation warning)

Screenshots

Before:
Screenshot 2023-11-28 at 11 10 00

After:
Screenshot 2023-11-28 at 11 10 21

TODO

n/a

Who to Notify

@camden11

@adamawang adamawang requested a review from camden11 November 28, 2023 16:19
@adamawang adamawang self-assigned this Nov 28, 2023
@adamawang adamawang merged commit b2d2711 into master Nov 28, 2023
1 check passed
@adamawang adamawang deleted the log-error-fix branch November 28, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants