Port error handlers to CLI #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ); | ||
| }; | ||
|
|
||
| const contactSupportString = |
There was a problem hiding this comment.
This copy should probably live in the translations file.
There was a problem hiding this comment.
Moved all copy from all 3 error files to lang file!
camden11
force-pushed
the
port-error-handlers
branch
from
9f9c630 to
26c3f86
Compare
brandenrodgers
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
See https://git.hubteam.com/HubSpot/hubspot-cli-issues/issues/481
The CLI uses these
errorHandlerutils to log errors in a user friendly fashion. Since they are interface related, we're moving them fromcli-libto the CLI. There is one instance inwebpack-cms-pluginswhere I had to copy some stuff over, but don't think that one spot is worth keeping these incli-libfor.Who to Notify
@brandenrodgers