Chore: convert lib/sandboxes and sandboxSync to TS #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camden11
requested review from
brandenrodgers,
kemmerle and
joe-yeager
as code owners
joe-yeager
reviewed
Jan 10, 2025
lib/sandboxes.ts
Outdated
Comment on lines
309
to
310
| 'error' in err && | ||
| err.error instanceof Error |
There was a problem hiding this comment.
I think this if statement might be unreachable code. if the isSpecifiedError is true, it is a HubSpotHttpError which doesn't have a error member on it
There was a problem hiding this comment.
Gotcha, I wasn't sure if we always knew the shape of HubSpotHttpErrors
camden11
changed the title
camden11
commented
Jan 10, 2025
| * @param {Boolean} skipPrompt - Option to skip contact records prompt and return all available sync tasks | ||
| * @returns {Array} Adjusted available sync task items | ||
| */ | ||
| const getSyncTypesWithContactRecordsPrompt = async ( |
There was a problem hiding this comment.
This function wasn't being used anywhere
camden11
commented
Jan 10, 2025
| accountName: name, | ||
| parentAccountName: uiAccountDescription(accountId), | ||
| accountId, | ||
| }) | ||
| ); | ||
| logger.log(''); | ||
| } else if ( |
There was a problem hiding this comment.
From what I can tell, all this code was unreachable. These cases were being handled ahead of time in validateSandboxUsageLimits
joe-yeager
previously approved these changes
Jan 10, 2025
commands/sandbox/create.ts
Outdated
| : typePrompt.type; | ||
|
|
||
| // Check usage limits and exit if parent portal has no available sandboxes for the selected type | ||
| try { | ||
| console.log('validate usage limit'); |
lib/sandboxes.ts
Outdated
| const id = getAccountIdentifier(accountConfig); | ||
| const accountId = getAccountId(id); | ||
|
|
||
| if (!accountId) { | ||
| throw new Error(`${i18nKey}.create.failure.usageLimitFetch`); |
There was a problem hiding this comment.
This log needs the i18n() function
lib/sandboxes.ts
Outdated
| const { | ||
| data: { usage }, | ||
| } = await getSandboxUsageLimits(accountId); | ||
| if (!usage) { | ||
| throw new Error('Unable to fetch sandbox usage limits. Please try again.'); | ||
| throw new Error(`${i18nKey}.create.failure.usageLimitFetch`); |
There was a problem hiding this comment.
Same here with i18n()
There was a problem hiding this comment.
Ooh good catch on these!
brandenrodgers
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
This converts lib/sandboxes and lib/sandboxSync to TS
Who to Notify
@brandenrodgers @kemmerle @joe-yeager