-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Convert prompts to TypeScript (final part) #1293
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kemmerle
requested review from
brandenrodgers,
camden11 and
joe-yeager
as code owners
December 5, 2024 21:11
kemmerle
changed the title
Convert prompts to TypeScript (final part)
chore: Convert prompts to TypeScript (final part)
Dec 5, 2024
camden11
reviewed
Dec 6, 2024
joe-yeager
reviewed
Dec 6, 2024
brandenrodgers
approved these changes
Dec 9, 2024
camden11
reviewed
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few more comments! Getting there!
camden11
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Depends on: HubSpot/hubspot-local-dev-lib#217 (Tests will pass, when this PR is merged)
As part of our continued work to convert the CLI to TypeScript, this PR finished converting the prompts in the
lib
folder. This completes our work convertinglib
subdirectories. The prompts include:personalAccessKeyPrompt
previewPrompt
projectAddPrompt
projectDevTargetAccountPrompt.ts
sandboxesPrompt
selectPublicAppPrompt
uploadPrompt
TODO
Who to Notify
@camden11 @brandenrodgers @joe-yeager