Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Convert prompts to TypeScript (final part) #1293

Merged
merged 17 commits into from
Dec 11, 2024
Merged

chore: Convert prompts to TypeScript (final part) #1293

merged 17 commits into from
Dec 11, 2024

Conversation

kemmerle
Copy link
Contributor

@kemmerle kemmerle commented Dec 5, 2024

Description and Context

Depends on: HubSpot/hubspot-local-dev-lib#217 (Tests will pass, when this PR is merged)

As part of our continued work to convert the CLI to TypeScript, this PR finished converting the prompts in the lib folder. This completes our work converting lib subdirectories. The prompts include:

personalAccessKeyPrompt
previewPrompt
projectAddPrompt
projectDevTargetAccountPrompt.ts
sandboxesPrompt
selectPublicAppPrompt
uploadPrompt

TODO

  • Address feedback

Who to Notify

@camden11 @brandenrodgers @joe-yeager

@kemmerle kemmerle changed the title Convert prompts to TypeScript (final part) chore: Convert prompts to TypeScript (final part) Dec 5, 2024
lib/prompts/createTemplatePrompt.ts Outdated Show resolved Hide resolved
lib/prompts/personalAccessKeyPrompt.ts Outdated Show resolved Hide resolved
lib/prompts/personalAccessKeyPrompt.ts Outdated Show resolved Hide resolved
lib/prompts/personalAccessKeyPrompt.ts Show resolved Hide resolved
lib/prompts/projectDevTargetAccountPrompt.ts Outdated Show resolved Hide resolved
types/prompts.ts Outdated Show resolved Hide resolved
types/prompts.ts Outdated Show resolved Hide resolved
lib/prompts/sandboxesPrompt.ts Outdated Show resolved Hide resolved
lib/prompts/sandboxesPrompt.ts Outdated Show resolved Hide resolved
lib/prompts/selectPublicAppPrompt.ts Outdated Show resolved Hide resolved
lib/prompts/personalAccessKeyPrompt.ts Outdated Show resolved Hide resolved
lib/prompts/projectDevTargetAccountPrompt.ts Show resolved Hide resolved
types/prompts.ts Outdated Show resolved Hide resolved
lib/prompts/selectPublicAppPrompt.ts Outdated Show resolved Hide resolved
Base automatically changed from convert/ts-5 to next December 6, 2024 20:14
@brandenrodgers brandenrodgers self-requested a review December 9, 2024 20:37
Copy link
Contributor

@camden11 camden11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more comments! Getting there!

types/prompts.ts Outdated Show resolved Hide resolved
lib/prompts/projectDevTargetAccountPrompt.ts Show resolved Hide resolved
@kemmerle kemmerle requested a review from camden11 December 11, 2024 17:07
@camden11 camden11 merged commit e34c6dc into next Dec 11, 2024
1 check passed
@camden11 camden11 deleted the convert/ts6 branch December 11, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants