diary 0.15 (new formula)

[in0rdr]

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

Requesting to add latest diary v0.15. Thank you for review.

[github-actions]

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

[in0rdr]

Thank you for the improvements @chenrui333 much appreciated

[SMillerDev]

Since these matches are regexes this will match anything. What is the expected output?

[in0rdr]

The expected output is defined here:

• https://code.in0rdr.ch/diary/file/src/diary.c.html#l559

The expected result code is 2 or 1 (for error). The error is written to stderr.

Can you help me with catching the shell output properly? When I try to use the actual error message in the assertion, I get an error.

For example, when I test like this:

assert_match "The directory 'na' does not exist", shell_output("DIARY_DIR=na #{bin}/diary", 2)

I get the following message for brew test diary:

An exception occurred within a child process:
  Minitest::Assertion: Expected /The\ directory\ 'na'\ does\ not\ exist/ to match "".

Could it be, that I need to add a special flag to assert_match or shell_output which allows me to check the message on stderr (not stdout)? Sorry, I'm new to this 🙈

[in0rdr]

Uhff, I think I found the "hack":

• Improve Homebrew::Assertions to provide access to stderr brew#5149 (comment)

This works, let me update the code for you

[in0rdr]

@SMillerDev can we add this note on how to check stderr with shell_output to the Formula Cookbook? I assume it's helpful for new users like me.