Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libadwaita: depend on sassc #204115

Merged
merged 2 commits into from
Jan 13, 2025
Merged

libadwaita: depend on sassc #204115

merged 2 commits into from
Jan 13, 2025

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Jan 13, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Currently, libadwaita installs sassc binary, which creates a conflict with sassc formula:

$ ls $(brew --prefix libadwaita)/bin
adwaita-1-demo  sassc

From what I see, sassc is required only to build stylesheets for libadwaita: https://gitlab.gnome.org/GNOME/libadwaita/-/blob/cfed18f13b1801493532ea415cb1d6ed3a351c0d/src/stylesheet/meson.build#L5-9

So it should be enough to add sassc as a build-time dependency

@chenrui333 chenrui333 added CI-no-bottles Merge without publishing bottles and removed CI-no-bottles Merge without publishing bottles labels Jan 13, 2025
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jan 13, 2025
@BrewTestBot BrewTestBot enabled auto-merge January 13, 2025 18:30
@BrewTestBot BrewTestBot added this pull request to the merge queue Jan 13, 2025
Merged via the queue into master with commit 2c79853 Jan 13, 2025
15 checks passed
@BrewTestBot BrewTestBot deleted the libadwaita-depend-on-sassc branch January 13, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants