Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fastbuild 1.14 (new formula) #204083

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fastbuild 1.14 (new formula) #204083

wants to merge 1 commit into from
+70 −0

Conversation

paperchalice
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Auditor still shows error even it is in style_exceptions/binary_bootstrap_formula_urls_allowlist.json.

@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request new formula PR adds a new formula to Homebrew/homebrew-core labels Jan 13, 2025
@paperchalice paperchalice force-pushed the fastbuild branch 2 times, most recently from 0bb4124 to 90abee7 Compare January 13, 2025 13:43
@carlocab carlocab added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Jan 13, 2025
@chenrui333
Copy link
Member 

  ==> /tmp/fastbuild-20250113-3638-53tkz5/fastbuild-1.14/bootstrap/fbuild All-x64Linux-Release
  3> Uni: FBuildTest-Unity-x64Linux-Release
  1> Error: opening file '/tmp/fastbuild-20250113-3638-53tkz5/fastbuild-1.14/Code/gcc-11' in Compiler ToolManifest
  FBuild: Error: BUILD FAILED: All-x64Linux-Release
  Time: 0.013s

@chenrui333 chenrui333 added build failure CI fails while building the software linux Linux is specifically affected labels Jan 13, 2025
@paperchalice paperchalice force-pushed the fastbuild branch 2 times, most recently from 68b5e11 to 5570dd8 Compare January 14, 2025 07:35
@paperchalice
Copy link
Contributor Author

Use GCC 11 now.

@chenrui333 chenrui333 removed build failure CI fails while building the software linux Linux is specifically affected CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Jan 14, 2025
chenrui333
chenrui333 approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Jan 15, 2025
@branchvincent branchvincent removed the automerge-skip `brew pr-automerge` will skip this pull request label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daeho-ro daeho-ro daeho-ro approved these changes

@chenrui333 chenrui333 chenrui333 approved these changes

Assignees
No one assigned
Labels
new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@paperchalice @chenrui333 @daeho-ro @branchvincent @carlocab