Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeaudit: deprecate #203881

Merged
merged 1 commit into from
Jan 11, 2025
Merged

kubeaudit: deprecate #203881

merged 1 commit into from
Jan 11, 2025

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Jan 10, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

We should consider deprecating kubeaudit since Shopify's team hasn't been able to keep up with maintenance and cannot currently be efficient stewards.

We believe kube-bench is a good successor.

relates to #203880


image

@chenrui333 chenrui333 added formula deprecated Formula deprecated CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. labels Jan 10, 2025
@github-actions github-actions bot added the go Go use is a significant feature of the PR or issue label Jan 10, 2025
@chenrui333 chenrui333 marked this pull request as draft January 10, 2025 22:35
Formula/k/kubeaudit.rb Outdated Show resolved Hide resolved
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 marked this pull request as ready for review January 11, 2025 03:13
@chenrui333 chenrui333 enabled auto-merge January 11, 2025 04:51
@chenrui333 chenrui333 added this pull request to the merge queue Jan 11, 2025
Merged via the queue into master with commit ca5a4b6 Jan 11, 2025
18 checks passed
@chenrui333 chenrui333 deleted the kubeaudit-deprecate branch January 11, 2025 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. formula deprecated Formula deprecated go Go use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants