Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql* 9.0.1, mysql-connector-c++ 9.0.0 #170446

Merged
merged 34 commits into from
Aug 4, 2024
Merged

mysql* 9.0.1, mysql-connector-c++ 9.0.0 #170446

merged 34 commits into from
Aug 4, 2024

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@chenrui333 chenrui333 added the long build Set a long timeout for formula testing label Apr 30, 2024
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request CI-linux-self-hosted Build on Linux self-hosted runner labels Apr 30, 2024
@chenrui333 chenrui333 added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Apr 30, 2024
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Apr 30, 2024
@chenrui333 chenrui333 added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label May 7, 2024
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label May 7, 2024
@timsutton timsutton added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label May 9, 2024
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label May 9, 2024
@chenrui333 chenrui333 added the in progress Stale bot should stay away label May 9, 2024
@SMillerDev
Copy link
Member

  /tmp/mysql-20240511-36861-s7mqxa/mysql-8.4.0/router/src/http/src/kdf_sha_crypt.cc:206:9: error: no matching member function for call to 'update'
        a.update({b_out.begin(), b_out.begin() + cnt});
        ~~^~~~~~
  /tmp/mysql-20240511-36861-s7mqxa/mysql-8.4.0/router/src/http/src/digest.h:94:8: note: candidate function not viable: cannot convert initializer list argument to 'const std::span<uint8_t>' (aka 'const span<unsigned char>')
    void update(const std::span<uint8_t> &data) {
         ^
  /tmp/mysql-20240511-36861-s7mqxa/mysql-8.4.0/router/src/http/src/digest.h:98:8: note: candidate function not viable: cannot convert initializer list argument to 'const std::string_view' (aka 'const basic_string_view<char>')
    void update(const std::string_view &data) {
         ^
  1 error generated.

@bevanjkay bevanjkay force-pushed the mysql-8.4.0 branch 2 times, most recently from 55b9357 to e33808c Compare May 23, 2024 05:50
grooverdan added a commit to grooverdan/mysqlclient-sys that referenced this pull request Jun 5, 2024
(8.4 lts currently having difficulties Homebrew/homebrew-core#170446)
grooverdan added a commit to grooverdan/mysqlclient-sys that referenced this pull request Jun 5, 2024
(8.4 lts currently having difficulties Homebrew/homebrew-core#170446)
grooverdan added a commit to grooverdan/mysqlclient-sys that referenced this pull request Jun 10, 2024
(8.4 lts currently having difficulties Homebrew/homebrew-core#170446)
grooverdan added a commit to grooverdan/mysqlclient-sys that referenced this pull request Jun 10, 2024
(8.4 lts currently having difficulties Homebrew/homebrew-core#170446)
weiznich pushed a commit to grooverdan/mysqlclient-sys that referenced this pull request Jun 12, 2024
@philip
Copy link
Contributor

philip commented Jun 25, 2024

Please provide an update for this as MySQL 8.3 is a dead branch whereas MySQL 8.4 is LTS. Does the MySQL team need to fix something upstream?

@mikepage
Copy link

mikepage commented Jul 9, 2024

A new release of MySQL 8.4 addresses cmake issues:
Updated BuildRequire rules to align with versions now required for CMake and Bison. (Bug #36343254)
https://dev.mysql.com/doc/relnotes/mysql/8.4/en/news-8-4-1.html

@github-actions github-actions bot added the CI-linux-self-hosted-deps Test dependents on Linux self-hosted runner label Jul 9, 2024
@SMillerDev SMillerDev changed the title mysql* 8.4.0 mysql* 9.0.0 Jul 9, 2024
@SMillerDev
Copy link
Member

Let's see if 9.0.0 works now

@yahonda
Copy link
Contributor

yahonda commented Jul 9, 2024

MySQL has two releases, Innovation and Long-Term Support.
MySQL 8.4.0 is the latest LTS release and MySQL 9.0.0 is the latest innovation release. So I think some people need MySQL 8.4.0.

Here is the blog post "Introducing MySQL Innovation and Long-Term Support (LTS) versions"
https://dev.mysql.com/blog-archive/introducing-mysql-innovation-and-long-term-support-lts-versions/

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Aug 4, 2024
@BrewTestBot BrewTestBot enabled auto-merge August 4, 2024 11:05
@BrewTestBot BrewTestBot added this pull request to the merge queue Aug 4, 2024
Merged via the queue into master with commit 41cd146 Aug 4, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the mysql-8.4.0 branch August 4, 2024 11:13
@Owersun
Copy link

Owersun commented Aug 5, 2024

mysql was tracking yesterday 8.3, and today it is 9.0.
If I didn't follow any beta upgrades or anything, after the "brew update" mysql is replaced to 9.0, and it doesn't start anymore with:
2024-08-04T15:56:52.273536Z 1 [ERROR] [MY-014060] [Server] Invalid MySQL server upgrade: Cannot upgrade from 80300 to 90001. Upgrade to next major version is only allowed from the last LTS release, which version 80300 is not.
Apparently skipping 8.4 entirely isn't the best idea.
Plus there is no mysql@8.4, only mysql-connector@8.4, and no mysql@8.3, so I can't return back to it, meaning there is no real way to start mysql anymore on top of existing database files.

@thinkverse
Copy link

For anyone who had the same issue as me and @Owersun who updated from 8.3 to 9.0.1, @simon-tma gave me a solution that worked in https://github.com/orgs/Homebrew/discussions/5539.

@Owersun
Copy link

Owersun commented Aug 5, 2024

That's obvious there could be two solutions to that:

  • download mysql 8.4 from third party, start it once on top of the files, delete after
  • delete all your database files, and just start mysql fresh (if you are developer it's no big deal)

But I would also prefer to run mysql 8.4 as LTS release, since it sounds like a proper release version which is going to be used in production and in development for a long time, until all unforeseen issues with 9.0 are resolved.

@nosnilmot
Copy link
Contributor

mysql@8.4 is on the way (imminently), it seems: #179792

@carlocab
Copy link
Member

carlocab commented Aug 5, 2024

Sorry for the pain! You should be able to

brew install mysql@8.4

now.

Comment on lines -50 to -55
# Patch out check for Homebrew `boost`.
# This should not be necessary when building inside `brew`.
# https://github.com/Homebrew/homebrew-test-bot/pull/820
patch do
url "https://raw.githubusercontent.com/Homebrew/formula-patches/bd61f2edc4c551856f894d307140b855edb2b4f5/mysql/boost-check.patch"
sha256 "b90c6f78fa347cec6388d2419ee4bc9a5dc9261771eff2800d99610e1c449244"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should've just updated this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I realized that when working on ICU PR. Just re-added patch there. I think it usually only happens when we do mega ICU PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. CI-skip-dependents Pass --skip-dependents to brew test-bot. in progress Stale bot should stay away long build Set a long timeout for formula testing new formula PR adds a new formula to Homebrew/homebrew-core no long build conflict Do not allow merging other pull requests when files conflict with this one ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.