Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

triage: label autobump PRs #166371

Merged
merged 1 commit into from
Mar 18, 2024
Merged

triage: label autobump PRs #166371

merged 1 commit into from
Mar 18, 2024

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@chenrui333 chenrui333 added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Mar 16, 2024
@chenrui333 chenrui333 requested review from MikeMcQuaid and a team as code owners March 16, 2024 22:45
@github-actions github-actions bot added the workflows PR modifies GitHub Actions workflow files label Mar 16, 2024
@github-actions GitHub Actions

This comment was marked as resolved.

Sign in to view
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Mar 16, 2024
@cho-m
Copy link
Member

cho-m commented Mar 17, 2024

Is this label intended for PRs that only modify the autobump.txt file (i.e. single commit/file PR)? Or for any PR that can also modify that file (i.e. multiple files/commits in PR)?

By default, label is only applied on former. Could try allow_any_match: true if you want the latter.

@chenrui333
Copy link
Member Author

Is this label intended for PRs that only modify the autobump.txt file (i.e. single commit/file PR)? Or for any PR that can also modify that file (i.e. multiple files/commits in PR)?

By default, label is only applied on former. Could try allow_any_match: true if you want the latter.

it would later, let me update that.

@chenrui333 @ZhongRuoyu
triage: label autobump PRs
5fb8061 
Signed-off-by: Rui Chen <rui@chenrui.dev>

triage: update syntax

Co-authored-by: Ruoyu Zhong <zhongruoyu@outlook.com>
@chenrui333 chenrui333 requested review from ZhongRuoyu and cho-m March 17, 2024 13:11
@chenrui333 chenrui333 removed the automerge-skip `brew pr-automerge` will skip this pull request label Mar 18, 2024
@chenrui333 chenrui333 added this pull request to the merge queue Mar 18, 2024
Merged via the queue into master with commit 6af755e Mar 18, 2024
18 checks passed
@chenrui333 chenrui333 deleted the label-autobump-prs branch March 18, 2024 01:28
MikeMcQuaid
MikeMcQuaid reviewed Mar 18, 2024
View reviewed changes
.github/workflows/triage.yml
@@ -240,3 +240,7 @@ jobs:

- label: pip-audit
pr_body_content: Created by `brew-pip-audit`

- label: autobump
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- label: autobump_txt or something feels more appropriate here?

@chenrui333 I expected from this label that it would be all the PRs that were created by the autobump workflow?

@chenrui333 chenrui333 mentioned this pull request Mar 30, 2024
Merged
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid left review comments

@fxcoudert fxcoudert fxcoudert approved these changes

@ZhongRuoyu ZhongRuoyu Awaiting requested review from ZhongRuoyu

@cho-m cho-m Awaiting requested review from cho-m

Assignees
No one assigned
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. outdated PR was locked due to age workflows PR modifies GitHub Actions workflow files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chenrui333 @cho-m @MikeMcQuaid @fxcoudert @ZhongRuoyu