Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read name and direction from AHB table headers #123

Merged
merged 52 commits into from
Dec 1, 2023
Merged

Read name and direction from AHB table headers #123

merged 52 commits into from
Dec 1, 2023

Conversation

hf-krechan
Copy link
Collaborator

No description provided.

hf-krechan and others added 18 commits April 10, 2023 18:26
@hf-krechan
🚧WIP
18e6db2
@hf-krechan
🚧🎨 Use new class TableHeader
9053890
@hf-krechan
🎨 Small improvements and a small fix
c54be85 
you can not remove empty string from list, if there is no empty string in list
@hf-krechan
🚨 Add docstrings
08238be
@hf-krechan
🚨Remove unused imports
3080790
@hf-krechan
🚨 Remove elif statement after continue
4ab14df
@hf-krechan
🚨 use enumerate instead of raneg
c993c13
@hf-krechan
🚨 Remove list comprehension
928411d
@hf-krechan
🎨 Use list comprehension
9fd385b
@hf-krechan
🚨 Ignore too few public methods
f6cc82d
@hf-krechan
🎨 Remove docstring from internal function
1894d12
@hf-krechan
🎨 Use falsy property in if condition
8930a6f
@hf-krechan
🚨 Improve code structure to remove some variables
a8a6bb7
@hf-krechan
✅ All checks pass
22edc5a
@hf-krechan
Merge branch 'main' into read-name-of-prüfis
cac01ab
@hf-krechan
🔥Remove old code
a830955
@hf-krechan
☝️ Add todo for later
d45903a
@hf-krechan
Merge remote-tracking branch 'origin/read-name-of-prüfis' into read-n…
27319d6 
…ame-of-prüfis
hf-krechan
hf-krechan commented Apr 11, 2023
View reviewed changes
Copy link
Collaborator Author

@hf-krechan hf-krechan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zwei Anmerkungen

src/kohlrahbi/table_header.py Outdated Show resolved Hide resolved
src/kohlrahbi/table_header.py Show resolved Hide resolved
@hf-krechan hf-krechan requested a review from hf-kklein April 11, 2023 09:45
hf-kklein
hf-kklein reviewed Apr 11, 2023
View reviewed changes
Copy link
Contributor

@hf-kklein hf-kklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich wünsche mir für die tabstop-magie noch einen test ;)

src/kohlrahbi/seed.py Show resolved Hide resolved
src/kohlrahbi/table_header.py Outdated Show resolved Hide resolved
src/kohlrahbi/table_header.py Show resolved Hide resolved
src/kohlrahbi/table_header.py Outdated Show resolved Hide resolved
src/kohlrahbi/table_header.py Show resolved Hide resolved
src/kohlrahbi/table_header.py Outdated Show resolved Hide resolved
src/kohlrahbi/table_header.py Outdated Show resolved Hide resolved
src/kohlrahbi/table_header.py Outdated Show resolved Hide resolved
src/kohlrahbi/table_header.py Outdated Show resolved Hide resolved
@hf-krechan hf-krechan mentioned this pull request Jul 11, 2023
Open
hf-krechan
hf-krechan commented Nov 27, 2023
View reviewed changes
unittests/test_unfolded_ahb_table.py Outdated
@@ -33,7 +33,9 @@ def test_is_dataelement(self):
pass

def test_convert_to_flat_ahb(self) -> None:
meta_data = UnfoldedAhbTableMetaData(pruefidentifikator="11016")
meta_data = UnfoldedAhbTableMetaData(
pruefidentifikator="11016", beschreibung="Nicht vorhanden", kommunikation_von="Nicht vorhanden"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pruefidentifikator="11016", beschreibung="Nicht vorhanden", kommunikation_von="Nicht vorhanden"
pruefidentifikator="55016", beschreibung="Kündigung beim alten Lieferanten", kommunikation_von="LFN an LFA"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

die 11er Prüfis sind veraltet, die gibt es nun nicht mehr. Habe es daher mal aktualisiert.

hf-sheese and others added 22 commits November 27, 2023 11:30
@hf-sheese
📝Extend documentation of create_mapping_of_tabstop_positions
3498f1e
@hf-sheese
Merge branch 'read-name-of-prüfis' of https://github.com/Hochfrequenz…
9f876ee 
…/kohlrahbi into read-name-of-prüfis
@hf-krechan
Merge branch 'main' into read-name-of-prüfis
c0f95de
@hf-krechan
✅ Add tests to test create_mapping_of_tabstop_positions
81d44af
@hf-krechan
🎨 use first and last from more_itertools
b867edd
@hf-krechan
💡 Add comment to the get_pruefidentifikator
e6a9aa5
@hf-krechan
🎨 Follow clean code style and create speakable conditions
7d9740b
@hf-sheese
📝Extend documentation to create_mapping_of_tabstopp_positions
26a0ea9
@hf-krechan
💡 Add explaining comments
eda7243
@hf-krechan
Merge branch 'read-name-of-prüfis' of https://github.com/Hochfrequenz…
af10ed6 
…/AHBExtractor into read-name-of-prüfis
@hf-krechan
🔥 Remove unused import
622638d
@hf-krechan
🚨 Fix mypy warning by ignoring the import
a6564c7
@hf-krechan
🚨 Fix linter warning
5f95ee0
@hf-sheese
Metadata is a dictionary instead of list
234dd79
@hf-sheese
✅test_unfolded_ahb_table
bf8002b
@hf-sheese
🚧Refactor from_header_cell
f881cef
@hf-krechan
🎨 Add docstrings
31db3a9
@hf-krechan
🎨 Use staticmethods
a139c7e
@hf-krechan
🚨 fix mypy issues
885186f
@hf-krechan
🎨 Fix my own bug ^^'
95c85d1
@hf-krechan
Revert "🎨 Use staticmethods"
23aa8bd 
This reverts commit a139c7e.
@hf-krechan
🎨 Use staticmethods again
b0d7b1e
@hf-krechan hf-krechan requested a review from hf-sheese November 30, 2023 17:32
hf-sheese
hf-sheese approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@hf-sheese hf-sheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meiner Meinung nach ist der PR reif zum Mergen.

@hf-sheese hf-sheese merged commit d4c9ab2 into main Dec 1, 2023
7 checks passed
@hf-sheese hf-sheese deleted the read-name-of-prüfis branch December 1, 2023 06:39
@hf-krechan hf-krechan restored the read-name-of-prüfis branch December 5, 2023 10:06
@hf-krechan hf-krechan deleted the read-name-of-prüfis branch December 21, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hf-kklein hf-kklein hf-kklein left review comments

@hf-sheese hf-sheese hf-sheese approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hf-krechan @hf-kklein @hf-sheese