feat: switch from edi-energy.de and scraping to bdew-mako.de and a real API; drop support for Python 3.9
#261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
January 1, 2025 14:08
because there's a real API now :)
for the api models
hf-kklein
commented
Jan 8, 2025
| @@ -2,7 +2,7 @@ | |||
| __pycache__/ | |||
| *.py[cod] | |||
| *$py.class | |||
|
|
|||
| foo | |||
hf-kklein
requested review from
lord-haffi,
hf-krechan,
DeltaDaniel and
OLILHR
hf-kklein
changed the title
edi-energy.de and scraping to bdew-mako.de and a real APIedi-energy.de and scraping to bdew-mako.de and a real API; drop support for Python 3.9
hf-kklein
commented
Jan 9, 2025
Comment on lines
+160
to
+170
| placeholder_values = { | ||
| "publication_date": (self.publicationDate or self.gueltig_ab).strftime("%Y%m%d"), | ||
| "from_date": self.gueltig_ab.strftime("%Y%m%d"), | ||
| "to_date": self.gueltig_bis.strftime("%Y%m%d"), | ||
| "extension": self.file_extension, | ||
| "id": str(self.fileId), | ||
| "kind": self.file_kind or self.alternative_file_kind, | ||
| "edifact_format": (self.edifact_format + "_" if self.edifact_format else ""), | ||
| "version": self.document_version or "NV", | ||
| } | ||
| return "{kind}_{edifact_format}{version}_{to_date}_{from_date}_{publication_date}_{id}.{extension}".format( |
There was a problem hiding this comment.
hier könnt ihr frei definieren, was wir alles in den dateinamen reinstecken.
mein innerer konflikt ist:
- entweder wir überladen den dateinamen mit allem was wir so brauchen
- oder wir legen die (aufbereiteten) metadaten in einer extra datei neben den PDFs und DOCx ab und lassen die "clients" diese metadaten dann separat einlesen.
hf-kklein
commented
Jan 9, 2025
| "edifact_format": (self.edifact_format + "_" if self.edifact_format else ""), | ||
| "version": self.document_version or "NV", | ||
| } | ||
| return "{kind}_{edifact_format}{version}_{to_date}_{from_date}_{publication_date}_{id}.{extension}".format( |
There was a problem hiding this comment.
beispiel-dateinamen findet ihr im snapshot: https://github.com/Hochfrequenz/edi_energy_scraper/blob/663f891e24545d1d556f9a25a0b200ffa562dc9d/unittests/__snapshots__/test_models.ambr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bitte einmal die
mwe.pyausführen und überzeugen, dass es gut ist :)bitte insbesondere auf die dateinamen achten, ob da aus eurer sicht alles wesentliche drin ist, zB. dass @hf-krechan @DeltaDaniel und @OLILHR daraus ableiten können, welches das richtige dokument für kohlrahbi, ahlbatross etc. ist.