Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrades bitcore-lib #658

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

tuliomir
Copy link
Contributor

@tuliomir tuliomir commented Jun 4, 2024

Acceptance Criteria

  • Upgrades bitcore-lib and bitcore-mnemonic from 8.25.10 to 10.0.36

Notes

Both the release notes, and the changelog file do not have any information about the major upgrades 9 and 10.

There is no v9 tag, and the v10 tag has no information about breaking changes. The only source of information to understand the changes are the commits themselves and they indicate no breaking changes.

Tests sending transactions and validating addresses were executed on the Desktop Wallet to ensure the client applications worked correctly and passed with no issues.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir added the dependencies Pull requests that update a dependency file label Jun 4, 2024
@tuliomir tuliomir self-assigned this Jun 4, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.67%. Comparing base (28f6f46) to head (4b3a4e3).

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #658       +/-   ##
===========================================
+ Coverage   62.55%   79.67%   +17.12%     
===========================================
  Files          77       77               
  Lines        5846     5846               
  Branches     1227     1214       -13     
===========================================
+ Hits         3657     4658     +1001     
+ Misses       2093     1171      -922     
+ Partials       96       17       -79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tuliomir tuliomir marked this pull request as ready for review June 4, 2024 23:17
@tuliomir tuliomir requested a review from pedroferreira1 as a code owner June 4, 2024 23:17
@tuliomir tuliomir requested review from andreabadesso, r4mmer and pedroferreira1 and removed request for pedroferreira1 and andreabadesso June 4, 2024 23:18
@tuliomir
Copy link
Contributor Author

This upgrade will wait for a next stage of the LavaMoat implementation on our clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants