Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(verification): add missing assertions #983

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Mar 25, 2024

Motivation

I noticed some verification tests were incorrect by a missing assertion.

Acceptance Criteria

  • Fix wrong Mock used in assertions from verify_pow_wrapped to verify_aux_pow_wrapped.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco added the tests label Mar 25, 2024
@glevco glevco self-assigned this Mar 25, 2024
@glevco glevco marked this pull request as ready for review March 25, 2024 18:34
Copy link
Member

@jansegre jansegre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, they weren't failing because verify_pow_wrapped is also called, but we want to make sure it calls verify_aux_pow_wrapped? So in theory we could leave both asserts then?

@glevco
Copy link
Contributor Author

glevco commented Mar 25, 2024

@jansegre yes, we want to assert that both of them are called. verify_pow_wrapped is already asserted a few lines above each changed line

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.06%. Comparing base (947db7b) to head (8723fc5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #983      +/-   ##
==========================================
- Coverage   85.14%   85.06%   -0.09%     
==========================================
  Files         295      295              
  Lines       22866    22866              
  Branches     3443     3443              
==========================================
- Hits        19470    19450      -20     
- Misses       2713     2725      +12     
- Partials      683      691       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco merged commit 881c5ff into master Apr 2, 2024
12 checks passed
@glevco glevco deleted the tests/fix-verification-test branch April 2, 2024 16:48
@jansegre jansegre mentioned this pull request Apr 5, 2024
2 tasks
@jansegre jansegre mentioned this pull request May 8, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants