-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change gen.cs file location #18
Conversation
Here's the code health analysis summary for commits Analysis Summary
|
Sorry about the previous ones pullrequests, sometimes GPG just kills 😁 |
I'm thinking of changing the Not sure however if it shouldn't just be left as The actual |
It seems to me that given the current and potential size of the project, this is not so important, I mean that there will be no confusion with the names and the name of the folder reflects its essence. As for the rest, yes, it’s really worth adding gen.cs to GeneratedFiles in gitignore. If you agree, then I will do it |
Good point You can change it, and I'll merge the PR. |
It seems like the build check is failing, which is probably just an issue with the workflow. I'll check if it builds correctly on my machine when I have time in about 2h and merge it. Gonna have to fix the workflow aswell |
The problem is that the compiler recognizes the Builtin class late. I tried to solve this, but did not find an adequate way to communicate the build time using code. |
After reading a bit, it turns out that everything that had to be done was just changing Sorry I'm finding out about this so late :/ I think if you could revert the commits in the PR and change |
Previously, your .csproj file was configured to create a gen.cs file. at the intermediate level ( Debug/.net/... ). Therefore, Visual Studio (possible problem with other code editors) cannot include the gen.cs file in the assembly. Because of this, I did not have the Builtin class (CS0246). So I moved the gen.cs file to the project root folder.