Fix map overlay caches not clearing when they should #2744
+29
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aches are cleared.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The ore/fluid vein caches for all map mods weren't clearing when they should've in singleplayer (except journeymap which worked unless the world name was the same or something weird like that), and ftb chunks and xaerox weren't clearing in multiplayer too.
Implementation Details
Added a method for clearing the cached overlays which is called when the client caches are cleared.
Outcome
Fixes #2742
Clarification
#2742 mentions that the ftb integration doesn't work, I couldn't get it not to work, it should be noted that the ftb integration is off by default since 9/10 modpacks contain at least 1 of the 2 other map mods which we have an integration for.
When a map mod integration is toggled the game should be restarted to allow for our map renderer to initialize the compatibility correctly.
Potential Compatibility Issues
Doesn't contain breaking changes.