Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Crafting Component Refactor (#2652)" #2708

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Revert "Crafting Component Refactor (#2652)" #2708

merged 2 commits into from
Jan 10, 2025

Conversation

krossgg
Copy link
Contributor

@krossgg krossgg commented Jan 10, 2025

What

This reverts commit 8aaf410, as it is a breaking change that should have been merged later.

@krossgg krossgg added the ignore changelog PR should not be added to the changelog. label Jan 10, 2025
@krossgg krossgg requested a review from a team as a code owner January 10, 2025 21:03
Ghostipedia
Ghostipedia approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@Ghostipedia Ghostipedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, Make sure someone re-opens the original PR/branch and re-pr's it eventually

@krossgg krossgg merged commit 242ff2f into 1.20.1 Jan 10, 2025
3 checks passed
@krossgg krossgg deleted the kr/crafting-revert branch January 10, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ghostipedia Ghostipedia Ghostipedia approved these changes

Assignees
No one assigned
Labels
ignore changelog PR should not be added to the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krossgg @Ghostipedia