Make setting crafting components from KJS more ergonomic. #2639
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Javascript objects only support strings as keys, so allow passing objects (i.e maps) with short tier names as keys for defining crafting components.
Outcome
Before (note in particular the need to import
Map
from java, rather than native JS syntax):After:
Potential Compatibility Issues
The functions now accept maps with either numbers (as now) or strings (which can be from native javascript objects), so the change should be backwards compatible.