Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hazards part 2 #1341

Merged
merged 7 commits into from
May 29, 2024
Merged

hazards part 2 #1341

merged 7 commits into from
May 29, 2024

Conversation

screret
Copy link
Member

@screret screret commented May 29, 2024

What

  • makes antidotes take off % of the effect time instead of a flat number
  • fixes component items applying the eating in finishUsingItem twice, reducing the stack size twice in the process
  • claned up how hazard effects are stored, ticked and tracked
  • made formaldehyde poisonous
  • added the ability for addons (or KJS) to register custom hazard types via just calling the constructor
  • made paracetamol an LV recipe if I did my stuff right

Implementation Details

"neat"
VAZKII

  • Ghostipedia

Outcome

makes hazards even more reasonable colon D

Additional Information

2024-05-29_15 44 01
2024-05-29_14 48 14

Potential Compatibility Issues

none as this system isn't published yet.

@screret screret requested a review from a team as a code owner May 29, 2024 13:51
@screret screret merged commit 093f964 into 1.20.1 May 29, 2024
2 checks passed
@screret screret deleted the sc/hazards-part-2 branch May 29, 2024 18:22
screret added a commit that referenced this pull request Jun 1, 2024
* fix component item eating happening twice

* make antidotes take off % of hazard time instead of a flat amount of it

* clean up how hazard effects are tracked and saved

* make paracetamol fully an LV recipe

* make formaldehyde an inhalation poison

* make it possible to add new hazard types (for custom lang keys etc.)

* spotless, datagen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants