Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sync CRDs inside "/crds" folder #3458

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jingyih
Copy link
Collaborator

@jingyih jingyih commented Jan 7, 2025

The public documentation on installing alpha CRDs still references the legacy "/crds" folder. Let's ensure it stays up to date.

$ dev/tasks/sync-crds-folder.sh 1.127.0

Copy link
Collaborator

@yuwenma yuwenma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold

Thanks for the change. I like the direction. There is actually a bigger issue we should fix to resolve the the alpha compatibility issue: The ./crds should be git-tag versioned together with the release version, otherwise users cannot apply a reliable ./crds

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jingyih
Copy link
Collaborator Author

jingyih commented Jan 8, 2025

Thanks for the change. I like the direction. There is actually a bigger issue we should fix to resolve the the alpha compatibility issue: The ./crds should be git-tag versioned together with the release version, otherwise users cannot apply a reliable ./crds

That makes sense. I was thinking we could run dev/tasks/sync-crds-folder.sh ${VERSION} as part of the release process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants