Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flex Template Composition for Dataflow #3440

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

svetakvsundhar
Copy link
Contributor

@svetakvsundhar svetakvsundhar commented Dec 20, 2024

This change adds a composition to deploy Dataflow Flex Templates. Note that this can be used to deploy Beam YAML pipelines.

Tested on DataflowRunner.

Screenshot 2024-12-20 at 3 00 18 PM

Fixes #

Tests you have done

  • Run make ready-pr to ensure this PR is ready for review.
  • Perform necessary E2E testing for changed resources.

Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from barney-s. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@svetakvsundhar svetakvsundhar marked this pull request as ready for review December 20, 2024 19:52
@svetakvsundhar
Copy link
Contributor Author

R: @barney-s
R: https://github.com/Polber/ (for a Beam YAML review).

A note: While we can pass in variables to the Beam YAML template via the parameters: --jinja_variables flag, I don't think this actually makes sense in practice. The Beam YAML template will already be staged in a GCS bucket, and it'll be an infra team executing KCC, and thus they shouldn't have access to modify Beam YAML pipeline parameters.

@svetakvsundhar
Copy link
Contributor Author

cc: https://github.com/hm98765

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants