DiscoveryEngineEngine controller #3400
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
justinsb
force-pushed
the
discoveryengineengine_controller
branch
5 times, most recently
from
ba90e2d to
05dc18f
Compare
|
We also use the common functions to resolve references (the last commit), cc @yuwenma |
justinsb
force-pushed
the
discoveryengineengine_controller
branch
from
05dc18f to
71536d5
Compare
It only takes the ID of the data store, not a full reference.
justinsb
force-pushed
the
discoveryengineengine_controller
branch
from
71536d5 to
e084674
Compare
justinsb
changed the title
|
/assign @yuwenma |
| @@ -65,7 +68,16 @@ func DiscoveryEngineEngineSpec_FromProto(mapCtx *direct.MapContext, in *pb.Engin | |||
| out.DisableAnalytics = direct.LazyPtr(in.GetDisableAnalytics()) | |||
|
|
|||
| for _, dataStoreID := range in.DataStoreIds { | |||
| out.DataStoreRefs = append(out.DataStoreRefs, &krm.DiscoveryEngineDataStoreRef{External: dataStoreID}) | |||
| tokens := strings.Split(in.Name, "/") | |||
There was a problem hiding this comment.
This (and the similar function below) is the trickiest thing in this PR, IMO. The GCP API expects only the data_store_id, and implicitly resolves the project / location / collection because (I guess) we can't go across projects / locations / collections.
justinsb
force-pushed
the
discoveryengineengine_controller
branch
from
e084674 to
85c0f34
Compare
We create the controller, a test and the mocks. I guess we could split out the mocks into their own PR, but this feels like a reasonable "chunk"