Refactor the stopListening function

GoogleChrome · Oct 15, 2024 · 403cb79 · 403cb79
1 parent 8e06644
commit 403cb79
Showing 1 changed file with 9 additions and 12 deletions.
diff --git a/src/onLCP.ts b/src/onLCP.ts
@@ -88,24 +88,21 @@ export const onLCP = (
       // so the callback is run in a separate task to avoid extending the
       // keyboard/click handler to reduce INP impact.
       // https://github.com/GoogleChrome/web-vitals/issues/383
-      const stopListening = () =>
-        whenIdleOrHidden(
-          runOnce(() => {
-            if (!reportedMetricIDs[metric.id]) {
-              handleEntries(po!.takeRecords() as LCPMetric['entries']);
-              po!.disconnect();
-              reportedMetricIDs[metric.id] = true;
-              report(true);
-            }
-          }),
-        );
+      const stopListening = runOnce(() => {
+        if (!reportedMetricIDs[metric.id]) {
+          handleEntries(po!.takeRecords() as LCPMetric['entries']);
+          po!.disconnect();
+          reportedMetricIDs[metric.id] = true;
+          report(true);
+        }
+      });
 
       // Stop listening after input or visibilitychange.
       // Note: while scrolling is an input that stops LCP observation, it's
       // unreliable since it can be programmatically generated.
       // See: https://github.com/GoogleChrome/web-vitals/issues/75
       for (const type of ['keydown', 'click', 'visibilitychange']) {
-        addEventListener(type, () => stopListening(), {
+        addEventListener(type, () => whenIdleOrHidden(stopListening), {
           capture: true,
           once: true,
         });