Only play one video in PiP at once. #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // If another video is already in PiP, pause it and exit PiP mode. | ||
| if (document.pictureInPictureElement instanceof VideoPlayer) { | ||
| document.pictureInPictureElement.videoElement.pause(); | ||
| await document.exitPictureInPicture(); |
There was a problem hiding this comment.
I believe await document.exitPictureInPicture(); is not necessary as document.pictureInPictureElement will exit Picture-in-Picture.
There was a problem hiding this comment.
@beaufortfrancois You're right, thank you. Updated in 599d9ab.
derekherman
approved these changes
Feb 1, 2022
|
LGTM. PiP displays one video at a time, and if a second video start on PiP, the first one stops. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When initializing the PiP experience, make sure no other video is playing. If it is, exit that PiP experience first and pause the previously playing video before opening a new PiP window.
Fixes #106 #178