Implement ConnectionStatus class. Fix online / offline mode issues. #104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #85
Fixes #94
Fixes #97
This PR introduces a few changes to the UI and refactors the way offline / online connection status is determined, reported and signaled.
There are a few notable changes, some of which deviate from the current state of things – those attempt to address the UX discrepancies reported under #85. Please review these changes one by one and LMK if you feel something needs to change. With the new underlying architecture in place, changes should be relatively simple.
Toggle button in the header now reads "Offline Mode" and its purpose is to toggle Offline Mode on and off.
Offline Mode button will refuse to deactivate when client is offline. Instead it will display a "Not connected" banner.
2021-03-16_18-53-02.mp4
There is no dangling banner on the screen indicating whether client is online or offline.
The "Show offline content only" button in settings now has the function as the Offline Mode button.
2021-03-16_18-56-42.mp4
Checklist