Fix key references for OT creation #4714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for a bug that emerged today regarding the submission of a deprecation trial on the OT creation request form.
Once the change was made to use OpenAPI models for this endpoint, the body of the OT creation request always contains the keys that represent the fields in the OT creation request form. Originally, it was assumed that sometimes the keys would not exist in the body dict, and the keys were accessed with this assumption (using the dict
.get()method and giving a default return value). Because the keys now always exist in the dictionary and are instead set toNoneif they are not provided in the requst, this causes some unintended errors accessing values.Despite appearing just after a recent deployment, this was a long-standing bug, but we have not received a deprecation trial creation request in some time. 🙂