Add origin trials to shipping stages check for oudated warnings (#4514)

* Add origin trials to shipping stages check for oudated warnings * Add all OT stages
GoogleChrome · Nov 1, 2024 · 06ee8b6 · 06ee8b6
1 parent 4dfd86d
commit 06ee8b6
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/client-src/elements/chromedash-feature-page.ts b/client-src/elements/chromedash-feature-page.ts
@@ -15,7 +15,10 @@ import './chromedash-feature-highlights.js';
 import {GateDict} from './chromedash-gate-chip.js';
 import {Process, ProgressItem} from './chromedash-gate-column.js';
 import {showToastMessage, isVerifiedWithinGracePeriod} from './utils.js';
-import {STAGE_TYPES_SHIPPING} from './form-field-enums';
+import {
+  STAGE_TYPES_SHIPPING,
+  STAGE_TYPES_ORIGIN_TRIAL,
+} from './form-field-enums';
 
 const INACTIVE_STATES = ['No longer pursuing', 'Deprecated', 'Removed'];
 declare var ga: Function;
@@ -159,9 +162,13 @@ export class ChromedashFeaturePage extends LitElement {
     }
 
     const shippingMilestones = new Set<number | undefined>();
-    // Get milestones from all shipping stages, STAGE_TYPES_SHIPPING.
+    const neededStageTypes = new Set<number>([
+      ...STAGE_TYPES_SHIPPING,
+      ...STAGE_TYPES_ORIGIN_TRIAL,
+    ]);
+    // Get milestones from all shipping stages.
     for (const stage of stages) {
-      if (STAGE_TYPES_SHIPPING.has(stage.stage_type)) {
+      if (neededStageTypes.has(stage.stage_type)) {
         shippingMilestones.add(stage.desktop_first);
         shippingMilestones.add(stage.android_first);
         shippingMilestones.add(stage.ios_first);

diff --git a/client-src/elements/chromedash-feature-page_test.ts b/client-src/elements/chromedash-feature-page_test.ts
@@ -374,6 +374,16 @@ describe('chromedash-feature-page', () => {
     assert.isTrue(component.isUpcoming);
     assert.isFalse(component.hasShipped);
     assert.equal(component.closestShippingDate, '2020-03-13T00:00:00');
+
+    component.closestShippingDate = '';
+    component.isUpcoming = false;
+    stages = structuredClone(feature.stages);
+    // Test with STAGE_BLINK_ORIGIN_TRIAL type.
+    stages[2].stage_type = 150;
+    component.findClosestShippingDate(channels, stages);
+    assert.isTrue(component.isUpcoming);
+    assert.isFalse(component.hasShipped);
+    assert.equal(component.closestShippingDate, '2020-03-13T00:00:00');
   });
 
   it('findClosestShippingDate() tests for hasShipped state', async () => {