Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patches: added Vanguard Saga of Heroes fix #128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

loisgomez
Copy link

@loisgomez loisgomez commented Dec 14, 2024

Context:
Vanguard Saga of Heroes is an MMORPG that was closed years ago by SOE.
The game is still alive in the emulator scene at https://vgoemulator.net/

The game seem to have relied on an old behaviour of the function SetCurrentDirectoryW( LPCWSTR dir )
which currently crashes the game.

This patch was a solution discovered by the community at https://vgoemulator.net/phpBB3/viewtopic.php?t=5563

Summary of changes:

  • Updates the function SetCurrentDirectoryW( LPCWSTR dir ) through a patch that removes the trailing ".".
  • Previously the game will try to access "bin\.Caches" and crash. It will now access "bin\Caches" and run successfully

Notes:

  • This is my first attempt to get this change upstream so the community does not have to rely on a custom build of Proton-GE and we can get the benefits of it being upstream
  • I am very unfamiliar with the wine codebase so this might not be the best way to fix the issue
  • I am new to the wine ecosystem so please do let me know if there is a better way to get this upstream

I have now submitted the change upstream to wine as well for review:

https://gitlab.winehq.org/wine/wine/-/merge_requests/7023

@GloriousEggroll
Copy link
Owner

heya thanks for this, it looks ok but I think it could use an envvar barrier at least until its accepted upstream. this way we can add a protonfix for it and it wont affect other games

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants