Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve all remaining parsing issues #21

Merged
merged 2 commits into from
Dec 16, 2024
Merged

fix: resolve all remaining parsing issues #21

merged 2 commits into from
Dec 16, 2024

Conversation

jsstevenson
Copy link
Member

  • Cycled through every possible FDA response and handled remaining ValueErrors
  • Add option to skip enum parsing errors if new ones arrive in the future and we can't resolve them immediately

@jsstevenson jsstevenson added the priority:medium Medium priority label Dec 16, 2024
@jsstevenson jsstevenson merged commit 5d03d91 into main Dec 16, 2024
16 checks passed
@jsstevenson jsstevenson deleted the validate-all-fda branch December 16, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korikuzma korikuzma korikuzma approved these changes

Assignees
No one assigned
Labels
priority:medium Medium priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsstevenson @korikuzma