Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix #81

Merged
merged 6 commits into from
Nov 9, 2024
Merged

Bugfix #81

merged 6 commits into from
Nov 9, 2024

Conversation

avantikalal
Copy link
Collaborator

@avantikalal avantikalal commented Nov 9, 2024 •
edited
Loading

Fixing bugs resulting from the recent tangermeme upgrade.

  1. read_modisco_report will work if only one of pos_patterns and neg_patterns is present
  2. tangermeme v>=0.4 is fixed in setup.cfg and also installed in the dockerfile.
  3. Fixed image paths in the modisco html

@avantikalal avantikalal requested a review from suragnair November 9, 2024 00:49
@avantikalal avantikalal merged commit e2ae40d into main Nov 9, 2024
2 checks passed
@avantikalal avantikalal deleted the bugfix branch November 9, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suragnair suragnair suragnair approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avantikalal @suragnair