Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace bpnetlite with tangermeme #15

Merged
merged 4 commits into from
Aug 21, 2024
Merged

replace bpnetlite with tangermeme #15

merged 4 commits into from
Aug 21, 2024

Conversation

avantikalal
Copy link
Collaborator

@avantikalal avantikalal commented Jul 10, 2024

  1. Updates all functions that use bpnetlite (get_gc_matched_negatives and dinuc_shuffle) to use tangermeme instead.
  2. Added start and end args to dinuc_shuffle since these are now available in tangermeme
  3. Removed bpnetlite from requirements.
  4. (To improve testing of datasets that use these functions) added the add_batch_axis argument to indices_to_one_hot
  5. (For consistency with other functions) Added the input_type argument to convert_input_type
  6. Updated tests
  7. Fixed a bug in marginalize_patterns caused by the seed not being passed to PatternMarginalizeDataset

Addresses #12

@gokceneraslan
Copy link
Collaborator

I'll leave this one to @suragnair

Copy link
Collaborator

@suragnair suragnair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@avantikalal avantikalal merged commit 1ca2765 into main Aug 21, 2024
1 check passed
@avantikalal avantikalal deleted the tangermeme_negatives branch August 21, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants