-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added documentation for REPL commands and :set-able options to reference manual #1790
base: master
Are you sure you want to change the base?
Added documentation for REPL commands and :set-able options to reference manual #1790
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for writing this up!
docs/RefMan/REPLCommands.rst
Outdated
**Valid values:** ``cvc4``, ``cvc5``, ``yices``, ``z3``, ``boolector``, | ||
``mathsat``, ``abc``, ``offline``, ``any``, ``sbv-cvc4``, ``sbv-cvc5``, | ||
``sbv-yices``, ``sbv-z3``, ``sbv-boolector``, ``sbv-mathsat``, ``sbv-abc``, | ||
``sbv-offline``, ``sbv-any``, ``w4-cvc4``, ``w4-cvc5``, ``w4-yices``, | ||
``w4-z3``, ``w4-boolector``, ``w4-abc``, ``w4-offline``, ``w4-any`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list should also include bitwuzla
, sbv-bitwuzla
, and w4-bitwuzla
.
docs/RefMan/REPLCommands.rst
Outdated
no argument, check all properties.) | ||
|
||
If the expression is successfully proven, the screen will display ``Q.E.D``. | ||
If not, the screen will display some counterexamples that return false. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think Cryptol ever displays multiple counterexamples, does it? Perhaps change the phrasing here to "will display a counterexample that returns false".
Does cryptol’s ‘satnum’ option influence :prove?.
…On Tue, Jan 14, 2025 at 7:23 AM Ryan Scott ***@***.***> wrote:
***@***.**** commented on this pull request.
Thank you for writing this up!
------------------------------
In docs/RefMan/REPLCommands.rst
<#1790 (comment)>:
> + **Valid values:** ``cvc4``, ``cvc5``, ``yices``, ``z3``, ``boolector``,
+ ``mathsat``, ``abc``, ``offline``, ``any``, ``sbv-cvc4``, ``sbv-cvc5``,
+ ``sbv-yices``, ``sbv-z3``, ``sbv-boolector``, ``sbv-mathsat``, ``sbv-abc``,
+ ``sbv-offline``, ``sbv-any``, ``w4-cvc4``, ``w4-cvc5``, ``w4-yices``,
+ ``w4-z3``, ``w4-boolector``, ``w4-abc``, ``w4-offline``, ``w4-any``
This list should also include bitwuzla, sbv-bitwuzla, and w4-bitwuzla
<#1787>.
------------------------------
In docs/RefMan/REPLCommands.rst
<#1790 (comment)>:
> +
+``:m [MODULE]``, ``:module [MODULE]``
+ Load a module by its name.
+
+``:module-deps MODULE``
+ Show information about the dependencies of a module.
+
+``:new-seed``
+ Randomly generate and set a new seed for the random number generator.
+
+``:prove [EXPR]``
+ Use an external solver to prove that the argument always returns true. (If
+ no argument, check all properties.)
+
+ If the expression is successfully proven, the screen will display ``Q.E.D``.
+ If not, the screen will display some counterexamples that return false.
I don't think Cryptol ever displays *multiple* counterexamples, does it?
Perhaps change the phrasing here to "will display a counterexample that
returns false".
—
Reply to this email directly, view it on GitHub
<#1790 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABYQSOWC35T2KK34IV7PPHD2KT6U3AVCNFSM6AAAAABVEVZP32VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNBZGU3DAMJSGA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Not to my knowledge, no. The source code suggests that cryptol/src/Cryptol/REPL/Command.hs Line 865 in 9e50047
( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last request: could you mention "fixes #612" somewhere in the commit message? That way, the issue will be automatically closed when the PR lands. Thanks!
f6fb6ab
to
98d98f5
Compare
Added documentation as requested in #612