refactor: address some code analysis issues

src/coreComponents/constitutive/fluid/multifluid/CO2Brine/functions/PhillipsBrineViscosity.hpp

@@ -143,7 +143,7 @@ void PhillipsBrineViscosityUpdate::compute( real64 const & pressure,
   using Deriv = constitutive::multifluid::DerivativeOffset;
 
   // compute the viscosity of pure water as a function of temperature
-  real64 dPureWaterVisc_dTemperature;
+  real64 dPureWaterVisc_dTemperature = 0.0;
   real64 const pureWaterVisc = m_waterViscosityTable.compute( &temperature, &dPureWaterVisc_dTemperature );
 
   // then compute the brine viscosity, accounting for the presence of salt

src/coreComponents/constitutive/solid/ElasticIsotropicPressureDependent.hpp

@@ -337,7 +337,7 @@ void ElasticIsotropicPressureDependentUpdates::smallStrainUpdate( localIndex con
   real64 eps_v_elastic;
   real64 oldElasticStrainVol;
   real64 oldElasticStrainDev;
-  real64 bulkModulus = -p0/Cr;
+  real64 bulkModulus;
 
   for( localIndex i=0; i<6; ++i )
   {

src/coreComponents/dataRepository/xmlWrapper.cpp

@@ -429,7 +429,7 @@ size_t findAttribute( string const & attName, string const & xmlBuffer, size_t c
         {
           return candidatePos;
         }
-        searchStart = candidatePos + attName.size();
+        //searchStart = candidatePos + attName.size();
       }
     }
     catch( std::regex_error const & )

src/coreComponents/fileIO/timeHistory/HistoryCollectionBase.cpp

@@ -189,9 +189,9 @@ dataRepository::Group const * HistoryCollectionBase::getTargetObject( DomainPart
           }
           else
           {
-            string const targetTokensStr = stringutilities::join( targetTokens.begin(),
-                                                                  targetTokens.begin()+pathLevel,
-                                                                  '/' );
+//            string const targetTokensStr = stringutilities::join( targetTokens.begin(),
+//                                                                  targetTokens.begin()+pathLevel,
+//                                                                  '/' );
             GEOS_THROW( targetTokens[pathLevel] << " not found in path " <<
                         objectPath << std::endl << targetGroup->dumpSubGroupsNames(),
                         std::domain_error );

src/coreComponents/mesh/utilities/StructuredGridUtilities.hpp

@@ -16,6 +16,10 @@
 #ifndef GEOS_MESH_UTILITIES_STRUCTUREDGRIDUTILITIES_HPP
 #define GEOS_MESH_UTILITIES_STRUCTUREDGRIDUTILITIES_HPP
 
+#include "common/logger/Logger.hpp"
+#include "common/GeosxMacros.hpp"
+#include <vector>
+
 /**
  * @file StructuredGridUtilities.hpp
  */

src/coreComponents/physicsSolvers/fluidFlow/kernels/compositional/SolutionScalingAndCheckingKernelBase.hpp

@@ -84,6 +84,7 @@ class SolutionScalingAndCheckingKernelBase
 
     StackVariables( real64 _localMinVal )
       :
+      localRow( -1 ),
       localMinVal( _localMinVal )
     { }
 

src/coreComponents/physicsSolvers/fluidFlow/kernels/singlePhase/ResidualNormKernel.hpp

@@ -21,6 +21,8 @@
 #define GEOS_PHYSICSSOLVERS_FLUIDFLOW_SINGLEPHASE_RESIDUALNORMKERNEL_HPP
 
 #include "physicsSolvers/PhysicsSolverBaseKernels.hpp"
+#include "mesh/ElementSubRegionBase.hpp"
+#include "physicsSolvers/fluidFlow/FlowSolverBaseFields.hpp"
 
 namespace geos
 {