Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: split compliance and build step #3260

Closed
wants to merge 8 commits into from
Closed

Conversation

untereiner
Copy link
Contributor

No description provided.

@untereiner untereiner self-assigned this Aug 1, 2024
@untereiner untereiner requested a review from rrsettgast as a code owner August 1, 2024 08:16
@untereiner untereiner closed this Aug 1, 2024
@untereiner untereiner reopened this Aug 1, 2024
@untereiner untereiner marked this pull request as draft August 1, 2024 09:01
@untereiner untereiner marked this pull request as ready for review August 1, 2024 09:33
@untereiner untereiner marked this pull request as draft August 1, 2024 13:31
@untereiner untereiner closed this Aug 1, 2024
@untereiner untereiner reopened this Aug 1, 2024
@untereiner untereiner marked this pull request as ready for review August 1, 2024 19:02
@untereiner untereiner force-pushed the ci/reusable_workflow branch from d7f7243 to 7c3e2a6 Compare August 1, 2024 19:11
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.89%. Comparing base (c2fe0d3) to head (4eacd1f).
Report is 111 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3260      +/-   ##
===========================================
- Coverage    55.89%   55.89%   -0.01%     
===========================================
  Files         1042     1042              
  Lines        88730    88730              
===========================================
- Hits         49600    49598       -2     
- Misses       39130    39132       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rrsettgast
Copy link
Member

@untereiner the way that these display in the actions tab is not good. There is no differentiation between the jobs on the summary/left bar.

@untereiner
Copy link
Contributor Author

@rrsettgast In the Pull Request workflow you have each job prefixed by the reusable workflow name:

  • Compliance Checks / semantic_pull_request
  • etc.
  • Build step / Ubuntu (20.04, gcc 9.4.0, open-mpi 4.0.3) / build_test_deploy
  • etc.

It is not ideal. I'll try something else

@rrsettgast rrsettgast closed this Aug 28, 2024
@rrsettgast
Copy link
Member

replaced with #3266

@untereiner untereiner deleted the ci/reusable_workflow branch August 28, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants