Feature/excalidraw #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for teaching-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lebalz
commented
Nov 24, 2024
| @@ -214,20 +214,26 @@ abstract class iDocument<Type extends DocumentType> { | |||
| } | |||
|
|
|||
| @action | |||
| _save() { | |||
| _save(onBeforeSave: () => Promise<void> = () => Promise.resolve()) { | |||
There was a problem hiding this comment.
new concept - if work needs to be done before saving (as generating the preview-image of excalidraw), a Promise can be passet to model.save and it will be called only when the debounced _save is called.
There was a problem hiding this comment.
Makes sense 👍 I could see this become useful in other future scenarios.
SilasBerger
approved these changes
Nov 25, 2024
| @@ -214,20 +214,26 @@ abstract class iDocument<Type extends DocumentType> { | |||
| } | |||
|
|
|||
| @action | |||
| _save() { | |||
| _save(onBeforeSave: () => Promise<void> = () => Promise.resolve()) { | |||
There was a problem hiding this comment.
Makes sense 👍 I could see this become useful in other future scenarios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excalidraw
Adds the type
Excalidocwhich contains the scene data of an excalidraw document. Excalidraw is a react library that is handy for quick drawings with simple geometries, pencils, text and images.👉 https://deploy-preview-50--teaching-dev.netlify.app/docs/komponentengalerie/excalidoc/
Stuff to do: