Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.1.0 : implemented hasXss function, compatibility with Laravel 5 #13

Closed
wants to merge 3 commits into from

Conversation

fireproofsocks
Copy link

This handles issues #11 and #12

@janhartigan
Copy link
Member

Thanks for putting this together. Several things to note:

  • Backwards-incompatible changes require a new major version.
  • The composer.json file should indicate that laravel 5 is required

Once these things are resolved, I merge this in.

@benjaminkohl
Copy link
Contributor

Speaking of versions, if you do consider pulling this, please push a tag for v1.0.0 or something before doing that. This is the one remaining package in my project's composer.json that just specifies "dev-master". I'd prefer to replace that with a specific version.

@scottconnerly
Copy link

+1 for a version tag. @fireproofsocks Can you please make those changes so this can get merged in?

@fireproofsocks
Copy link
Author

Sorry to be confused here, but what exactly do you need changed? My git shui is weak. Do you need a tag added and pushed?

@janhartigan
Copy link
Member

@fireproofsocks basically just bump the readme to 2.0.0 instead of 1.1.0.

@fireproofsocks
Copy link
Author

Sorry, I'm not clear on what you mean by bumping the readme. Could you clarify? Apropos, I added this: #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants