Remove patch of window.Promise.prototype.constructor
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greenberga
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Go for it—to be honest, I don't have a strong enough intuition for how this might impact our signals pipeline because I don't have a great sense of how it uses the information. So I'm deferring to you. But generally, I'm in favor of minimizing tracking where possible :)
greenberga
reviewed
Dec 11, 2024
| @@ -79,7 +79,6 @@ export const takeRecords = (function () { | |||
|
|
|||
| // We save some bundle size by using these constants. | |||
There was a problem hiding this comment.
Now I guess it's just "this constant", but feel free to ignore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not confident we can patch this constructor without causing issues down the line, be it in Angular or other libraries that mess with
Promise- so I decided to remove it entirely.I think one way that we could keep it would be to use
Reflect.construct, but that doesn't have wide enough browser support (no IE11).In other libraries where
Promisewas replaced entirely, such as in New Relic's browser agent [1] [2] it would subtly break existing website code. Now we only patch the constructor.. maybe there is some way, but I wasn't able to find a way that I'm confident in.If we ever choose to re-introduce that, we must make sure to make that a major version bump.