Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.1.10] Fix use of modern ES features for some Safari/iPhone versions #21

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

gzuidhof
Copy link
Contributor

A slice of browsers (and devices locked to that version) were affected, namely Safari 11.1 and 12.1. They would display a SyntaxError upon loading the SDK.

This was fixed by explicitly targeting es6. Additionally we avoid some other modern JS features to save on bundle size (saving a bit over 4% of bundle size).

@gzuidhof gzuidhof added the bug Something isn't working label Nov 27, 2024
@gzuidhof gzuidhof requested a review from greenberga November 27, 2024 21:58
@gzuidhof gzuidhof self-assigned this Nov 27, 2024
@gzuidhof gzuidhof requested a review from mikemherron November 27, 2024 23:37
@gzuidhof gzuidhof merged commit 5f6f267 into main Nov 28, 2024
2 checks passed
@gzuidhof gzuidhof deleted the fix-new-es-syntax-use branch November 28, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants