-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: possible cd pathing issue #163
Conversation
feat: Freaky image is in town
- updated readme with BMAC
- Wiki configured and now control details are moved to the Wiki.
…id build errors (#11) * fix: starter commit * Update README.md * Update README.md * fix: fixed build errors if apps target maccatalyst and windows * Update README.md updated readme + added headers * Update README.md * feat: Signature view basic setup * fix: compelete setup for a signature view * Create issues.md Template for issues * feat: A fully setup SignatureView that can help you create signature's + better sample * fix: code cleanup * feat: SignatureView is a readySignatureView * chore: code clesn up * Delete issues.md Co-authored-by: Gulam Ali Hakim <jimtiyg@Gulams-MacBook-Pro.local>
* fix: memory leak fixes * fix: code clean up for signaturePadview * fix: files moved to helper * fix: events moved post ctor Co-authored-by: Gulam Ali Hakim <jimtiyg@Gulams-MacBook-Pro.local>
* fix: Circular Image now inherits from our Image control * fix: update changes for some controls
* fix: Circular Image now inherits from our Image control * fix: update changes for some controls * chore: code cleanup * fix: changes to signatureview * fix: clear icon instead of label * fix: ui changes for signature view * fix: updated clear icon * fix:SignatureView is optimized and cleaned up * chore: updated readme.md * Update README.md updated license in readme * fix: signature view now has better documentation * fix: signature view now has better documentation * fix: better positioming for clear icon
* fix: icon fix for nupkg * Update README.md - Added SignatureView for iOS * Update README.md fix: added screenshots for all controls :) * Update README.md updated the readme * Update README.md a better readme in general :) * Update README.md
* feat: merging new features to master (#14) * feat: Freaky image is in town :) * feat: Picker, DatePicker and Timepicker just got Freaky :D * fix: handled some warnings * feat: some changes to our files :) * fix: TIL * feat: TextInputLayout now has an outlined option :) * fix: removed unwanted parts of the code * fix: background color is now transparent for entry view * feat: freaky image added for descriptions * feat: final update for your freaky controls * Update README.md - updated readme with BMAC * Update README.md - Wiki configured and now control details are moved to the Wiki. * fix: more information on properties * feat: A UI for signatures + Handlers for unsupported platforms to avoid build errors (#11) * fix: starter commit * Update README.md * Update README.md * fix: fixed build errors if apps target maccatalyst and windows * Update README.md updated readme + added headers * Update README.md * feat: Signature view basic setup * fix: compelete setup for a signature view * Create issues.md Template for issues * feat: A fully setup SignatureView that can help you create signature's + better sample * fix: code cleanup * feat: SignatureView is a readySignatureView * chore: code clesn up * Delete issues.md Co-authored-by: Gulam Ali Hakim <jimtiyg@Gulams-MacBook-Pro.local> * fix: code clean up and other fixes for performance (#16) * fix: memory leak fixes * fix: code clean up for signaturePadview * fix: files moved to helper * fix: events moved post ctor Co-authored-by: Gulam Ali Hakim <jimtiyg@Gulams-MacBook-Pro.local> * fix: Circular Image now comes from our control. (#17) * fix: Circular Image now inherits from our Image control * fix: update changes for some controls * fix: code clean up and updates (#18) * fix: Circular Image now inherits from our Image control * fix: update changes for some controls * chore: code cleanup * fix: changes to signatureview * fix: clear icon instead of label * fix: ui changes for signature view * fix: updated clear icon * fix:SignatureView is optimized and cleaned up * chore: updated readme.md * Update README.md updated license in readme * fix: signature view now has better documentation * fix: signature view now has better documentation * fix: better positioming for clear icon * chore: setup for 0.3 (#19) Co-authored-by: Gulam Ali Hakim <jimtiyg@Gulams-MacBook-Pro.local> * Update Maui.FreakyControls.csproj Co-authored-by: Gulam Ali Hakim <jimtiyg@Gulams-MacBook-Pro.local>
* fix: better visuals for readme and other changes (#22) * feat: Freaky image is in town :) * feat: Picker, DatePicker and Timepicker just got Freaky :D * fix: handled some warnings * feat: some changes to our files :) * fix: TIL * feat: TextInputLayout now has an outlined option :) * fix: removed unwanted parts of the code * fix: background color is now transparent for entry view * feat: freaky image added for descriptions * feat: final update for your freaky controls * Update README.md - updated readme with BMAC * Update README.md - Wiki configured and now control details are moved to the Wiki. * fix: more information on properties * feat: A UI for signatures + Handlers for unsupported platforms to avoid build errors (#11) * fix: starter commit * Update README.md * Update README.md * fix: fixed build errors if apps target maccatalyst and windows * Update README.md updated readme + added headers * Update README.md * feat: Signature view basic setup * fix: compelete setup for a signature view * Create issues.md Template for issues * feat: A fully setup SignatureView that can help you create signature's + better sample * fix: code cleanup * feat: SignatureView is a readySignatureView * chore: code clesn up * Delete issues.md Co-authored-by: Gulam Ali Hakim <jimtiyg@Gulams-MacBook-Pro.local> * fix: code clean up and other fixes for performance (#16) * fix: memory leak fixes * fix: code clean up for signaturePadview * fix: files moved to helper * fix: events moved post ctor Co-authored-by: Gulam Ali Hakim <jimtiyg@Gulams-MacBook-Pro.local> * fix: Circular Image now comes from our control. (#17) * fix: Circular Image now inherits from our Image control * fix: update changes for some controls * fix: code clean up and updates (#18) * fix: Circular Image now inherits from our Image control * fix: update changes for some controls * chore: code cleanup * fix: changes to signatureview * fix: clear icon instead of label * fix: ui changes for signature view * fix: updated clear icon * fix:SignatureView is optimized and cleaned up * chore: updated readme.md * Update README.md updated license in readme * fix: signature view now has better documentation * fix: signature view now has better documentation * fix: better positioming for clear icon * chore: setup for 0.3 (#19) * fix: fix for nupkg and readme now has gifs (#20) * fix: icon fix for nupkg * Update README.md - Added SignatureView for iOS * Update README.md fix: added screenshots for all controls :) * Update README.md updated the readme * Update README.md a better readme in general :) * Update README.md * fix: updated readme for better visual effects (#21) * feat: merging new features to master (#14) * feat: Freaky image is in town :) * feat: Picker, DatePicker and Timepicker just got Freaky :D * fix: handled some warnings * feat: some changes to our files :) * fix: TIL * feat: TextInputLayout now has an outlined option :) * fix: removed unwanted parts of the code * fix: background color is now transparent for entry view * feat: freaky image added for descriptions * feat: final update for your freaky controls * Update README.md - updated readme with BMAC * Update README.md - Wiki configured and now control details are moved to the Wiki. * fix: more information on properties * feat: A UI for signatures + Handlers for unsupported platforms to avoid build errors (#11) * fix: starter commit * Update README.md * Update README.md * fix: fixed build errors if apps target maccatalyst and windows * Update README.md updated readme + added headers * Update README.md * feat: Signature view basic setup * fix: compelete setup for a signature view * Create issues.md Template for issues * feat: A fully setup SignatureView that can help you create signature's + better sample * fix: code cleanup * feat: SignatureView is a readySignatureView * chore: code clesn up * Delete issues.md Co-authored-by: Gulam Ali Hakim <jimtiyg@Gulams-MacBook-Pro.local> * fix: code clean up and other fixes for performance (#16) * fix: memory leak fixes * fix: code clean up for signaturePadview * fix: files moved to helper * fix: events moved post ctor Co-authored-by: Gulam Ali Hakim <jimtiyg@Gulams-MacBook-Pro.local> * fix: Circular Image now comes from our control. (#17) * fix: Circular Image now inherits from our Image control * fix: update changes for some controls * fix: code clean up and updates (#18) * fix: Circular Image now inherits from our Image control * fix: update changes for some controls * chore: code cleanup * fix: changes to signatureview * fix: clear icon instead of label * fix: ui changes for signature view * fix: updated clear icon * fix:SignatureView is optimized and cleaned up * chore: updated readme.md * Update README.md updated license in readme * fix: signature view now has better documentation * fix: signature view now has better documentation * fix: better positioming for clear icon * chore: setup for 0.3 (#19) Co-authored-by: Gulam Ali Hakim <jimtiyg@Gulams-MacBook-Pro.local> * Update Maui.FreakyControls.csproj Co-authored-by: Gulam Ali Hakim <jimtiyg@Gulams-MacBook-Pro.local> Co-authored-by: Gulam Ali Hakim <jimtiyg@Gulams-MacBook-Pro.local> * chore: feature request template Co-authored-by: Gulam Ali Hakim <jimtiyg@Gulams-MacBook-Pro.local>
* feat:support for .net7 * fix: updated samples
* fix: basic freaky checkbox is here * fix: checkbox handler * fix: issue with TIL background color now works * feat: Hello Checkbox * feat: Freaky checkbox is ready to rule * fix: bug fixes and code clean up * fix: design issues and more * Update README.md fix: added checkbox images to readme
* fix: clean up and invalidate for SvgImageView * fix: rewrote freaky entry to have better image and focus performance * fix: code clean up and more * fix: code clean up and some packages downgraded * fix: removed unneccesary try-catch * fix: clean up * fix: converters updated * fix: clean up * fix: added events to freakypincodecontrol
- Added ability for layout to handle numeric fontsize values - Added new TitleFontSize property so user can change the size of the floating label - Fixed floating label positioning for various TitleFontSizes - Fixed margins for Bordered input type so the floating label doesn't overlap with a control above it
* Fix crash when switching the app's theme between dark/light modes Fix crash when switching the app's theme between dark/light modes * Fix crash when switching the app's theme between dark/light modes Fix crash when switching the app's theme between dark/light modes * Fix app theme change crash for picker and datepicker Fix app theme change crash for picker and datepicker --------- Co-authored-by: e071324 <Danny.Neumann@odfl.com>
…159) * fix: version 0.5.0 is here with some updates (#137) * fix: proj file clean up * feat: Release CI-CD for ease of release (#149) * feat: Release CI-CD for ease of release * fix: ci for packages * fix: quick fix for command FreakyPicker.cs * fix: vulnerability changes for SkiaSharp * Update main_cd.yml (#150) * Update main_cd.yml (#151) * Update main_cd.yml (#152)
* by removing an extra copy of FreakyZoomableView
…minimum levels (#160) Co-authored-by: Hakim Gulam Ali <hakimgulamali@Hakims-MacBook-Pro.local>
WalkthroughThe pull request modifies the GitHub Actions workflow file Changes
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/main_cd.yml (1)
25-25
: Consider using forward slashes for better cross-platform compatibilityWhile backslashes work on Windows, PowerShell handles forward slashes perfectly well. Using forward slashes would make the workflow more portable if you ever need to run it on other platforms.
- run: dotnet pack MAUI.FreakyControls\MAUI.FreakyControls\Maui.FreakyControls.csproj -c Release -p:PackageVersion=${{ steps.get_version.outputs.version-without-v }} + run: dotnet pack MAUI.FreakyControls/MAUI.FreakyControls/Maui.FreakyControls.csproj -c Release -p:PackageVersion=${{ steps.get_version.outputs.version-without-v }}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/main_cd.yml
(2 hunks)
🔇 Additional comments (2)
.github/workflows/main_cd.yml (2)
15-15
: Verify the default branch name of the repository
The change from 'origin/main' to 'origin/master' needs verification to ensure it matches the repository's actual default branch.
✅ Verification successful
Branch verification step correctly references 'origin/master'
The change from 'origin/main' to 'origin/master' in the workflow file is correct as the repository's default branch is confirmed to be 'master'.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the repository's default branch
# Expected: Should show 'master' as the default branch
# Check the default branch name
gh repo view --json defaultBranchRef --jq .defaultBranchRef.name
Length of output: 73
Line range hint 27-30
: Fix environment variable configuration and consider path consistency
- The
GITHUB_TOKEN
environment variable is incorrectly set to useNUGET_API_KEY
. This appears to be unnecessary as the NuGet push command already uses the API key directly. - The path to the .nupkg file uses backslashes, which should be consistent with the previous step's decision.
Remove the unnecessary environment variable:
run: dotnet nuget push MAUI.FreakyControls\MAUI.FreakyControls\bin\Release\FreakyControls.${{ steps.get_version.outputs.version-without-v }}.nupkg -s https://api.nuget.org/v3/index.json -k ${{ secrets.NUGET_API_KEY }}
- env:
- GITHUB_TOKEN: ${{ secrets.NUGET_API_KEY }}
Let's verify the .nupkg file path will exist:
✅ Verification successful
Remove unnecessary GITHUB_TOKEN and maintain path consistency
-
The project structure confirms that the .nupkg file path will exist after build since:
- The project file has
GeneratePackageOnBuild
set to true for Release configuration - The package ID is correctly set to
FreakyControls
in the project file - The build output path follows standard .NET conventions
- The project file has
-
The review comment is correct about:
- The unnecessary
GITHUB_TOKEN
environment variable that should be removed - Path separator consistency issue with backslashes
- The unnecessary
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the project structure matches the expected paths
# Expected: Should find the .csproj file in the specified location
fd -e csproj . MAUI.FreakyControls
Length of output: 146
Script:
#!/bin/bash
# Check the project file content to verify build output configuration
cat MAUI.FreakyControls/MAUI.FreakyControls/Maui.FreakyControls.csproj
Length of output: 8277
Summary by CodeRabbit