Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace SkiaSharp.Svg by Svg.Skia #154

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Replace SkiaSharp.Svg by Svg.Skia #154

merged 1 commit into from
Dec 13, 2024

Conversation

janusw
Copy link
Contributor

@janusw janusw commented Oct 10, 2024

fixes #153

This was referenced Oct 10, 2024
Closed
Merged
rafageist
rafageist reviewed Nov 15, 2024
View reviewed changes
Copy link

@rafageist rafageist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this migration is a positive step, it should be carefully tested to verify that everything functions as expected with Svg.Skia before merging.

@FreakyAli
Copy link
Owner

While this migration is a positive step, it should be carefully tested to verify that everything functions as expected with Svg.Skia before merging.

That's the reason you don't see this being merged already, haven't gotten a chance to test this!

Will only be merged once tested

@janusw
Copy link
Contributor Author

janusw commented Nov 15, 2024

I actually stopped caring by now. 🤷

Anyhow this library is way too buggy for productive use (for my purposes) and in a pretty bad state (maintenance-wise).

@FreakyAli
Copy link
Owner

I actually stopped caring by now. 🤷

Anyhow this library is way too buggy for productive use (for my purposes) and in a pretty bad state (maintenance-wise).

Oh I'm sorry for the inconveniences, but I have a full time job, I do this in my free time ✌️

@FreakyAli FreakyAli merged commit 241068e into FreakyAli:master Dec 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafageist rafageist rafageist left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace SkiaSharp.Svg
3 participants
@janusw @FreakyAli @rafageist