Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-PVM visual glitch #241

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Fix multi-PVM visual glitch #241

merged 1 commit into from
Dec 9, 2024

Conversation

wkwiatek
Copy link
Collaborator

@wkwiatek wkwiatek commented Dec 9, 2024

Fixes: #225

Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for pvm-debugger ready!

Name Link
🔨 Latest commit 4e1ac12
🔍 Latest deploy log https://app.netlify.com/sites/pvm-debugger/deploys/6756d64e3868ce00085453ad
😎 Deploy Preview https://deploy-preview-241--pvm-debugger.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wkwiatek wkwiatek merged commit a48eb4d into main Dec 9, 2024
6 checks passed
@wkwiatek wkwiatek deleted the fix/memory-multi-pvm-glitch branch December 9, 2024 11:47
krystian50 added a commit that referenced this pull request Dec 15, 2024
* Fix multi-PVM visual glitch (#241)

* Don't perform multiple steps when Stepping in the UI. (#240)

* Fix multi-PVM visual glitch (#243)

* Modify program editor to be available only in edit mode; improve error handling (#242)

* Move program code input to edit mode

* Handle errors in program text editor

* Allow for hex in array as a program input

* Fix linter

* refactor

---------

Co-authored-by: Wojciech Kwiatek <wojtek.kwiatek@gmail.com>
Co-authored-by: Tomek Drwięga <tomusdrw@users.noreply.github.com>
krystian50 added a commit that referenced this pull request Jan 8, 2025
* refactor steps state

* Add host call example

* Add host calls component

* Add write host-call

* Add host calls to pvm

* Add host calls to pvm

* change service id

* Do not stop debugger on host call

* Show host call popup when status is HOST; move logic to separated worker message

* Ensure run is working properly

* Fix linter

* refactor

* Host calls cleanup (#251)

* Fix multi-PVM visual glitch (#241)

* Don't perform multiple steps when Stepping in the UI. (#240)

* Fix multi-PVM visual glitch (#243)

* Modify program editor to be available only in edit mode; improve error handling (#242)

* Move program code input to edit mode

* Handle errors in program text editor

* Allow for hex in array as a program input

* Fix linter

* refactor

---------

Co-authored-by: Wojciech Kwiatek <wojtek.kwiatek@gmail.com>
Co-authored-by: Tomek Drwięga <tomusdrw@users.noreply.github.com>

* Revert "Host calls cleanup (#251)" (#252)

This reverts commit 78fde84.

* Add trie inputs

* Add trie input

* fix hex val and empty key

* Store write host call data

* format valueblob

* fix write host call

* Change layout

* workarounds for other pvms

* Fix object freeze issue

* fix error handling

* remove unused files

* remove comments

* remove comments

* Add service id

* no error fo empty storage record

* change pvm generated hash

* fix lint

* fix batched steps

* fix continue after host call

* fix type error

* Move setting service id

* Change set service id

---------

Co-authored-by: Wojciech Kwiatek <wojtek.kwiatek@gmail.com>
Co-authored-by: Tomek Drwięga <tomusdrw@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory is not displayed correctly
1 participant