Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cleaner recordHook error messages #327

Merged
merged 6 commits into from
Nov 27, 2023

Conversation

carlbrugger
Copy link
Contributor

@carlbrugger carlbrugger commented Nov 17, 2023

This PR makes error messages readable (👋🏼 FiberFailure)

Test with:

listener.use(
  recordHook(
    'contacts',
    async (r: FlatfileRecord): Promise<FlatfileRecord> => {
      throw new Error("opps")
    }
  )
)

@carlbrugger carlbrugger self-assigned this Nov 17, 2023
Copy link

Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@flatfile/util-common 0.2.3...0.2.4 None +0/-0 29.7 kB flatfileinfra

🚮 Removed packages: @flatfile/utils-testing@0.0.5

@ashleygmulligan2 ashleygmulligan2 self-requested a review November 27, 2023 15:52
Copy link
Contributor

@ashleygmulligan2 ashleygmulligan2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this expose anything sensitive in our platform to end users? I think this q is actually a platform q.

@carlbrugger carlbrugger merged commit f18a889 into main Nov 27, 2023
4 checks passed
@carlbrugger carlbrugger deleted the feat/readable-recordHook-error-messages branch November 27, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants