Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch build tool for recordHook & autocast plugins and include UMD build for recordHook #313

Merged
merged 6 commits into from
Dec 8, 2023

Conversation

brentkulwicki
Copy link
Contributor

This includes a umd build in the dist folder so we can reach this package via CDN

@brentkulwicki brentkulwicki marked this pull request as draft November 8, 2023 14:11
@brentkulwicki
Copy link
Contributor Author

This is not yet building with types. Need to get the types building in again before this will be ready.

@brentkulwicki brentkulwicki marked this pull request as ready for review November 8, 2023 15:31
@brentkulwicki brentkulwicki marked this pull request as draft November 8, 2023 15:59
@brentkulwicki
Copy link
Contributor Author

Now seeing an error with creating in the CDN builds after adding types. Moving back to draft so this doesn't get accidentally merged

@brentkulwicki
Copy link
Contributor Author

So the UMD builds are throwing this error:
image

In testing this out, this seems to indicate that this fetchData function is the culprit and even more granular, it appears that the line const data = await event.data is where this fails
image

@ashleygmulligan2
Copy link
Contributor

Tests are failing here. @brentkulwicki and @carlbrugger please pair on resolving.

@brentkulwicki
Copy link
Contributor Author

@ashleygmulligan2 theres still a bug after I made some additional changes that I haven't been able to track down. This is marked as draft PR until that gets resolved.

@bangarang bangarang force-pushed the umd-builds-for-record-hooks branch from 741c73f to 553f5b4 Compare December 1, 2023 16:21
@carlbrugger carlbrugger changed the title record hook plugin using rollup so umd builds can be included feat: switch build tool for recordHook & autocast plugins and include UMD build for recordHook Dec 8, 2023
@carlbrugger carlbrugger marked this pull request as ready for review December 8, 2023 01:20
@carlbrugger carlbrugger merged commit 9d36229 into main Dec 8, 2023
4 checks passed
@carlbrugger carlbrugger deleted the umd-builds-for-record-hooks branch December 8, 2023 01:20
@carlbrugger
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants