-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure Space with YAML Plugin #312
Conversation
Want to put a note here, the failing tests are due to the zip-extractor plugin, I'll probably figure out what's wrong with it in another PR. Edit: Tests passing locally, not sure why they're failing here |
After rerunning the tests in debug they're passing. I wonder if it's something with async timing since the tests are somewhat slower when debug is enabled? |
Co-authored-by: Carl Brugger <carl.brugger@flatfile.io>
…FlatFilers/flatfile-plugins into feat/yaml-schema-implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some more review, I realized I jumped the gun when I removed the code from JSON schema, so this last commit undoes those changes. I feel it is best to keep JSON Schema unchanged and add the DRYed up YAML code, and then DRY up the JSON schema in a separate PR. LMK if there's a better way to do this!
I agree! |
Co-authored-by: Carl Brugger <carl.brugger@flatfile.io>
Co-authored-by: Carl Brugger <carl.brugger@flatfile.io>
Co-authored-by: Carl Brugger <carl.brugger@flatfile.io>
Co-authored-by: Carl Brugger <carl.brugger@flatfile.io>
Co-authored-by: Carl Brugger <carl.brugger@flatfile.io>
Co-authored-by: Carl Brugger <carl.brugger@flatfile.io>
Co-authored-by: Carl Brugger <carl.brugger@flatfile.io>
New and updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
After troubleshooting this for a bit, I have realized that the reason it's failing was because this was built around the changes to JSON-schema I reverted. I was able to patch around it, but it'll take some refactoring after release when we transition json-schema to DRY it up overall. |
Also I had to revert one of the JSON -> YAML corrections due to how the plugin uses the JSON-schema plugin and it using the default defined in JSON-Schema and it's not redefined anywhere in YAML-Schema |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Guide: https://flatfile.com/docs/plugins/schemas/convert-yaml-schema
Kitchen Sink: WIP
This PR introduces the
@flatfile/plugin-convert-yaml-schema
plugin to configure a Flatfile Space based on a provided YAML Schema. The usage for this plugin closely mirrors@flatfile/plugin-convert-json-schema
.Basic Usage
Advanced Usage
Closes: No associated Issue or Track.