Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:process-records-utility #284

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

carlbrugger
Copy link
Contributor

@carlbrugger carlbrugger commented Oct 19, 2023

This PR introduces a utility for applying a callback on all records in a sheet.

Plugins to update:

  • Automap
  • Dedupe
  • Export-workbook
  • Merge-connection
  • Webhook-egress
  • Utils/response-rejection
  • Utils/testing

@socket-security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@flatfile/api 1.5.30...1.5.32 None +69/-0 4.38 MB flatfileinfra

@carlbrugger carlbrugger marked this pull request as ready for review October 19, 2023 20:13
@ashleygmulligan2 ashleygmulligan2 merged commit 82da1b9 into main Oct 19, 2023
3 checks passed
@ashleygmulligan2 ashleygmulligan2 deleted the feat/process-records-utility branch October 19, 2023 20:22
@dboskovic
Copy link
Contributor

This approach is fine-ish but we should be careful about things that allocate so much memory. Can we default to not returning the aggregate results and make that a configurable option if you absolutely need to?

@carlbrugger carlbrugger mentioned this pull request Oct 24, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants