feat: restructure test & console.log -> console.error

FlatFilers · Nov 20, 2023 · 2114c00 · 2114c00
1 parent 285a772
commit 2114c00
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 15 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/plugins/record-hook/src/RecordHook.ts b/plugins/record-hook/src/RecordHook.ts
@@ -27,7 +27,9 @@ export const RecordHook = async (
           try {
             await handler(record, event)
           } catch (e) {
-            console.log(`An error occurred while running the handler: ${e}`)
+            console.error(
+              `An error occurred while running the handler: ${e.message}`
+            )
           }
         })
       )

diff --git a/plugins/record-hook/src/record.hook.e2e.spec.ts b/plugins/record-hook/src/record.hook.e2e.spec.ts
@@ -69,29 +69,29 @@ describe('recordHook() e2e', () => {
   })
 
   describe('recordHook errors', () => {
+    const logErrorSpy = jest.spyOn(global.console, 'error')
     beforeEach(async () => {
       listener.use(
         recordHook('test', (record) => {
           throw new Error('oops')
         })
       )
-    })
-    it('returns readable error', async () => {
-      const logSpy = jest.spyOn(global.console, 'log')
       await createRecords(sheetId, [
         {
           name: 'John Doe',
           email: 'john@doe.com',
           notes: 'foobar',
         },
       ])
-
+    })
+    it('returns readable error', async () => {
       await listener.waitFor('commit:created')
-
-      expect(logSpy).toHaveBeenCalledWith(
-        'An error occurred while running the handler: Error: oops'
+      expect(logErrorSpy).toHaveBeenCalledWith(
+        'An error occurred while running the handler: oops'
       )
-      logSpy.mockRestore()
+    })
+    afterEach(() => {
+      logErrorSpy.mockClear()
     })
   })
 })