feat: include id from props not config

FlatFilers · Apr 26, 2024 · 399f9cc · 399f9cc
1 parent 8e3949f
commit 399f9cc
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/apps/react/app/re-used-space/App.tsx b/apps/react/app/re-used-space/App.tsx
@@ -93,8 +93,8 @@ const App = () => {
         </button>
       </div>
       <Space
+        id={SPACE_ID}
         config={{
-          id: SPACE_ID,
           metadata: {
             sidebarConfig: {
               showSidebar: true,

diff --git a/packages/react/src/components/Space.tsx b/packages/react/src/components/Space.tsx
@@ -5,7 +5,7 @@ import { useDeepCompareEffect } from '../utils/useDeepCompareEffect'
 
 type SpaceProps = {
   id?: string
-  config: Flatfile.SpaceConfig
+  config?: Flatfile.SpaceConfig
   children?: React.ReactNode
 }
 
@@ -33,11 +33,14 @@ type SpaceProps = {
  */
 
 export const Space = (props: SpaceProps) => {
-  const { config, children } = props
+  const { config, id, children } = props
   const { updateSpace } = useContext(FlatfileContext)
 
   const callback = useCallback(() => {
-    updateSpace(config)
+    updateSpace({
+      ...(config || {}),
+      id,
+    })
   }, [config, updateSpace])
 
   useDeepCompareEffect(callback, [config])