Multiple fixes and improvements to the FirestoreMixin #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when one document in a collection changes, an entirely new array is assigned to a property. It does not work well with dom-repeats, iron-lists etc. This change lays the groundwork for a more efficient solution.
This change fixes an issue which occurs when observed/bound properties are defined prior to a call of `connectedCallback`. Since _firestoreUpdateBinding method handles null and undefined values correctly, the `if` statement can be safely removed.
…d in FirestoreMixin.
…n FirestoreMixin.
This was referenced Jan 5, 2018
|
Thanks for this @merlinnot I'll merge it now so I can add this in my review list |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #294, #298, #299, #301, #303
Resolves #283, resolves #284, resolves #287, resolves #300, resolves #302