Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared/RBAC network support #605

Open
wants to merge 28 commits into
base: mitaka
Choose a base branch
from
Open

Conversation

abattye
Copy link

@abattye abattye commented Jun 9, 2017

This contains the necessary driver updates to support the shared network model in this agent pull request F5Networks/f5-openstack-agent#763

@jlongstaf
Copy link
Contributor

For the is_common_network() change, we need to coordinate Andrew's request with @ssorenso . Steven is working on supporting common networks in the agent. His change there implements is_common_network() based on a setting in the agent INI file, instead of forcing to true as in this patch. Steven's work accomplishes what this patch wants, but gives user control in order to support legacy behavior.

@abattye
Copy link
Author

abattye commented Jul 15, 2017

My patch just displays intent, its not indended as a final solution, as we discussed we're more than happy for this to be configurable to support legacy scenarios.

There are however a few other fixes included in these changes that make the sync work more consistently and catch a few edge cases, it woud be great if these didn't get lost along the way.

@pjbreaux
Copy link
Contributor

Can one of the admins verify this patch?

@ssorenso
Copy link

Please also disregard the comment from @pjbreaux:
Can one of the admins verify this patch?

This is dust from a set of items we're attempting to do in our background.

@pjbreaux
Copy link
Contributor

pjbreaux commented Aug 7, 2017

Can one of the admins verify this patch?

1 similar comment
@pjbreaux
Copy link
Contributor

pjbreaux commented Sep 8, 2017

Can one of the admins verify this patch?

@pjbreaux
Copy link
Contributor

Can one of the admins verify this patch?

@amudukutore
Copy link
Contributor

@abattye - if you'd like to have these merged into master, can you rebase these on top of tree? Also, if you only care about the most recent changes (RPC functions for RBAC network support), can you submit those as a separate pull request?

* Changes in error handling when objects can't be found for orphan handling and in case scheduling for agent failed

* Try 6 times to get an network and don't use bad defaults for the provider segment id and network type in case that the first try fails.
Throw exeption if 6 tries fail for the read of network info.

* Fix the _get_network_cached method and make it work again. First approach for fixing was completely nonsense

* Add network segments to the 30 minute cache for networks.

* Enable caching for network segmentation retrieval. Change defaults for network segmentation dict in case not found.

* Changes in error handling when objects can't be found for orphan handling and in case scheduling for agent failed

* Try 6 times to get an network and don't use bad defaults for the provider segment id and network type in case that the first try fails.
Throw exeption if 6 tries fail for the read of network info.

* Fix the _get_network_cached method and make it work again. First approach for fixing was completely nonsense

* Add network segments to the 30 minute cache for networks.

* Enable caching for network segmentation retrieval. Change defaults for network segmentation dict in case not found.
tlesmann added 6 commits July 6, 2018 11:45
…trieval

Fix wrong retry logic for missing segments.
Fix bindings assignment in case no agent ist live
…or. Schedule lb's to overloaded agent in case partition is already scheduled. Clean orphan cache every 24 h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants